Skip to content

Fixes compilation warnings regarding #![allow(missing_doc)] #18816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

zachwick
Copy link

@zachwick zachwick commented Nov 9, 2014

Signed-off-by: zachwick zach@zachwick.com

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

Signed-off-by: zachwick <zach@zachwick.com>
@japaric
Copy link
Member

japaric commented Nov 10, 2014

@sfackler #18808 is very similar to this PR (this one is actually a superset of that PR), perhaps we should close that one in favor of this one?

cc @huonw

@alexcrichton
Copy link
Member

@zachwick, could you rebase to lose the extra merge commit? Thanks!

@japaric this handles sys/windows/mod.rs while #18808 doesn't, I'll comment over there to see if we can only send one of these to bors.

@alexcrichton
Copy link
Member

Aha actually #18808 updated to include windows so this is now a full dupe of #18808, so closing. Thanks @zachwick regardless!

@zachwick
Copy link
Author

You're welcome; Glad I could be of help, if only to serve as a catalyst for someone else to update their PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants